-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ux: add warning when cabal reads from no index cache #10258
base: master
Are you sure you want to change the base?
Conversation
@taimoorzaeem great work, thanks! Could you, please, add manual-QA notes in the PR description? This would be a step-by-step guide showing what it takes to see the effect of your patch locally. This will start with build cabal from your branch (obvious). But then, what do I do to see the warning? Step by step. You could attach any sample files that could help to set up a no-index repository etc. Example of MQA notes is in the description of #9200 |
You'll also have to make fourmolu and whitespace checkers happy (see the github action failures linked from this page). |
Would be great to add a test. See for guidance: https://github.com/haskell/cabal/blob/master/cabal-testsuite/README.md#how-to-write |
90b29cf
to
0c1092e
Compare
@ulysses4ever @andreabedini When exactly does cabal create a local |
@taimoorzaeem I don't know the answer to your last question from the top of my head, sadly. I could try to dig over the weekend maybe. But in the meantime: can you locally observe the effect of your patch? In other words, the message you added --- can you make |
37 tests affected by the current change (they fail now), but most (all?) of them are seemingly unrelated:
|
No, I am not able to observe the effect locally. That's because I am not sure when exactly cabal create a local no index cache. The warning message is only supposed to be printed when this cache file is created by cabal. Since I am not a much advanced user of cabal, I would like some you folks' help. @andreabedini Could you help out on how I should go about testing/qa it locally? |
Fixes #9136.
Since, I am a new contributor, I didn't follow the provided PR template and wrote what I thought would be best in this PR. Let me know if following the provided PR template is necessary.
@andreabedini Please check if that is the right place for the warning and let me know about changes. I'll work on adding the tests next.